Conversation
Contributor
|
Adding a test for this issue would be nice. |
Contributor
Author
I struggle to create a passing unit test for it or my solution is not 100% correct. |
Contributor
|
Adding more info in the commit msg with the corner case would be nice. |
Contributor
|
CI is red |
rgonzalezfluendo
requested changes
May 5, 2026
Contributor
rgonzalezfluendo
left a comment
rgonzalezfluendo
left a comment
There was a problem hiding this comment.
- Add a good commit msg
- Drop debug prints
rgonzalezfluendo
approved these changes
May 6, 2026
This commit fixes an issue found when trying to remove a feature where the previous feature was an `integrated` feature. This commit does: 1. Let _sync to select the `prev_feature` value 2. Ignore integrated features when marking the target branch as the last feature Issue: RDI_3208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: RDI_3208