blog: Add Fluentd v1.17.0 release announcement - #312
Merged
Conversation
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
cosmo0920
reviewed
May 14, 2024
cosmo0920
left a comment
cosmo0920
left a comment
Contributor
There was a problem hiding this comment.
I added quite small nitpicks. Could you read carefully and get used to be usage of , (comma) and enumeration of two or more items with and?
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
Contributor
Author
Thanks! I understand! I will take care of that! |
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
cosmo0920
reviewed
May 15, 2024
cosmo0920
left a comment
cosmo0920
left a comment
Contributor
There was a problem hiding this comment.
Also, I found errors where are newly added sections.
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
marked this pull request as ready for review
June 6, 2024 00:00
daipom
changed the title
Contributor
Author
cosmo0920
reviewed
Jun 6, 2024
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
Contributor
Author
|
@cosmo0920 Thanks for your review! |
Contributor
|
@kenhys Do you have any concerns? If there is no concerns, it's ready to |
!
Contributor
Author
Contributor
Author
|
Thanks! |
Contributor
Author
|
@cosmo0920 @kenhys @ashie Thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/fluent/fluentd/releases/tag/v1.17.0