Replace $$ with Process.pid - #4040
Merged
Merged
Conversation
`Process.pid` is easier to understand. Signed-off-by: abetomo <abe@enzou.tokyo>
abetomo
force-pushed
the
use_process_pid
branch
from
February 6, 2023 15:09
8b24e2a to
ede9de8
Compare
Member
|
GJ! Thanks! |
Member
|
Failed tests are known issue, they aren't concerned with this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
( #4034 (comment) )
What this PR does / why we need it:
Simply replace
$$withProcess.pid.Process.pidis easier to read and understand.Docs Changes:
Release Note: