Skip to content

refactor: test/test_supervisor.rb - #4044

Merged
ashie merged 3 commits into
fluent:masterfrom
abetomo:refactor_test_supervisor
Feb 8, 2023
Merged

refactor: test/test_supervisor.rb#4044
ashie merged 3 commits into
fluent:masterfrom
abetomo:refactor_test_supervisor

Conversation

@abetomo

@abetomo abetomo commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

What this PR does / why we need it:

  • test: use double quotes for strings containing line breaks
  • test: use .& for nil check
  • test: remove begin rescue end when Process.kill

Docs Changes:

Release Note:

Signed-off-by: abetomo <abe@enzou.tokyo>
Signed-off-by: abetomo <abe@enzou.tokyo>
It is more helpful to the investigation if the exception is not ignored.

Signed-off-by: abetomo <abe@enzou.tokyo>

@kou kou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ashie
ashie merged commit aeac168 into fluent:master Feb 8, 2023
@ashie

ashie commented Feb 8, 2023

Copy link
Copy Markdown
Member

Thanks!

@abetomo
abetomo deleted the refactor_test_supervisor branch February 8, 2023 00:13
@ashie ashie added this to the v1.16.0 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants