Update Webrick - #4061
Conversation
|
TODO confirm test results. |
|
All Windows tests fail: The fluentd command fails by |
These tests have failed before as well. In my local Ruby3.1 on Windows 10 Home, all tests in |
|
I will run all tests in my local Ruby3.2 on Windows 10 Home. |
|
I have confirmed all tests are successful on my local environment.
|
|
I rerun CI for this PR a few times but always fail on Windows platform & all Ruby versions. They output suspicious log after finishing test: |
|
Thanks for confirming! |
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
|
I'm not sure what was going on, but it looks fine now? |
|
I'm not sure what was happening, but now this seems to be working with no problem. |
|
Thanks! |
|
Thanks for your review! |
Which issue(s) this PR fixes:
Fixes #4060
What this PR does / why we need it:
This PR allows us to use the latest
Webrickv1.8.https://github.com/ruby/webrick/releases
Without this fix, plugins using the latest version of
Webricktries to bundle the Fluentd v1.12.1.Docs Changes:
Not needed.
Release Note:
Not needed.