Skip to content

Use driver for RegexpParser tests - #4085

Merged
ashie merged 1 commit into
fluent:masterfrom
abetomo:use-driver-for-parser_regexp-tests
Mar 9, 2023
Merged

Use driver for RegexpParser tests#4085
ashie merged 1 commit into
fluent:masterfrom
abetomo:use-driver-for-parser_regexp-tests

Conversation

@abetomo

@abetomo abetomo commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

( #4066 (comment) )

What this PR does / why we need it:

I didn't know why it was commented out, but it looked good on Fluent::Test::Driver::Parser.new(...).
#1286

Docs Changes:

None

Release Note:

None

Signed-off-by: abetomo <abe@enzou.tokyo>
@daipom
daipom self-requested a review March 9, 2023 01:16

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should fix tests like this.

Certainly, the intent of the #1286 fix is unclear.

Fluent::Test::Driver::Parser::configure() calls instance.configure(), so I think the old code is meaningless.

I have confirmed the test succeeds even on #1286 with this fix.

It looks good to me.

@ashie
ashie merged commit 8812ec1 into fluent:master Mar 9, 2023
@ashie

ashie commented Mar 9, 2023

Copy link
Copy Markdown
Member

Thanks!

@ashie ashie added this to the v1.16.0 milestone Mar 9, 2023
@abetomo
abetomo deleted the use-driver-for-parser_regexp-tests branch March 9, 2023 03:36
@abetomo

abetomo commented Mar 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants