Raise minimum required ruby version - #4288
Merged
Merged
Conversation
kenhys
force-pushed
the
fix-required-ruby-version
branch
from
September 5, 2023 07:02
2f0b312 to
a933dff
Compare
Contributor
|
Thanks! |
Contributor
Author
|
It depends on perspective:
Created PR based on the former, but reconsidered it should be the latter. Thanksm, I'll fix it. |
The service discovery plugin helper use Array#prepend, it means that the ruby version must be 2.5 or later precisely. fluentd.work/lib/fluent/plugin_helper/service_discovery.rb:71:in `service_discovery_configure': undefined method `prepend' for []:Array (NoMethodError) from /work/fluent/fluentd/fluentd.work/lib/fluent/plugin/out_ NOTE: It works with Ruby 2.5 or later, but 2.x had already reached EOL. At least, it may better to set verified version with CI. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
fix-required-ruby-version
branch
from
September 6, 2023 07:41
a933dff to
4b2b2dd
Compare
Contributor
Author
|
Fixed. |
daipom
approved these changes
Sep 6, 2023
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
It depends on perspective:
* Precisely set minimum: * Pros: can run a bit older even though already reached EOL. * Cons: allow non-supported version to run with. * Only set CI certified version: * Pros: can recommend verified version with CI. * Cons: cut off ruby version actually work.Created PR based on the former, but reconsidered it should be the latter.
Thanksm, I'll fix it.
I see!
At least, we need this fix.
We can think about whether we should update the version to 2.7 or not later.
Contributor
Thanks! |
Contributor
Author
When td-agent reached EOL (Dec, 2023), we will drop 2.7 from CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
The service discovery plugin helper use Array#prepend, it means that the ruby version must be 2.5 or later precisely.
fluentd.work/lib/fluent/plugin_helper/service_discovery.rb:71:in
service_discovery_configure': undefined methodprepend' for[]:Array (NoMethodError) from
/work/fluent/fluentd/fluentd.work/lib/fluent/plugin/out_
Docs Changes:
fluent/fluentd-docs-gitbook#471
Release Note:
N/A