Drop unused @_plugin_id_configured from all own-able plugins - #4320
Merged
Conversation
isimluk
force-pushed
the
minor-perf
branch
2 times, most recently
from
October 16, 2023 09:45
4fb1484 to
557daf7
Compare
Contributor
|
Sorry, it may be a week or two before I can review this. |
Member
ashie
self-requested a review
October 17, 2023 03:58
ashie
approved these changes
Oct 17, 2023
This variable is unused since b32781d. Signed-off-by: Šimon Lukašík <isimluk@fedoraproject.org>
daipom
approved these changes
Dec 19, 2023
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
Thanks.
Sorry for the delay in merging this.
Now, I merge this to the master branch for v1.17.0.
Note: It seems that we don't need @_plugin_id either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable is unused since b32781d.