test: use IO#popen instead of Kernel#open - #4369
Merged
Merged
Conversation
open("|command") spawns command and create pipes for
processing pipeline.
This feature of Kernel#open is deprecated, replace it with
IO#popen.
It fixes the following warning:
warning: Calling Kernel#open with a leading '|' is deprecated and will
be removed in Ruby 4.0; use IO.popen instead
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
ashie
self-requested a review
January 10, 2024 02:29
Merged
Watson1978
added
the
backport to v1.16
daipom
pushed a commit
that referenced
this pull request
Dec 9, 2025
Backport #4369 **Which issue(s) this PR fixes**: N/A **What this PR does / why we need it**: open("|command") spawns command and create pipes for processing pipeline. This feature of Kernel#open is deprecated, replace it with IO#popen. It fixes the following warning: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Kentaro Hayashi <hayashi@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
open("|command") spawns command and create pipes for processing pipeline.
This feature of Kernel#open is deprecated, replace it with IO#popen.
It fixes the following warning:
warning: Calling Kernel#open with a leading '|' is deprecated and will
be removed in Ruby 4.0; use IO.popen instead
Docs Changes:
N/A
Release Note:
N/A