Conversation
ashie
changed the title
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
changed the title
Member
Author
|
BTW I'm considering to stop running CI for Ruby head on |
ashie
marked this pull request as ready for review
January 11, 2024 02:36
kenhys
requested changes
Jan 11, 2024
kenhys
left a comment
kenhys
left a comment
Contributor
There was a problem hiding this comment.
Basically LGTM except typo.
…ables Make easy to understand what these tests do. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Behaviour of `IO#set_encoding` has been changed as of Ruby 3.3. We don't yet determine how to solve this issue, it might be better to address in Ruby. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Contributor
|
Oops, it seems that applied "Rebase and merge" accidentally. |
Merged
ashie
added a commit
that referenced
this pull request
Mar 11, 2024
Backport (v1.16): Fix or suppress failed tests on Ruby 3.3 (#4375)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
Fix failed tests on Ruby 3.3.
They seem just only test's problem except #4058, no need to fix fluentd itself.
For #4058, we have to decide whether to fix in fluentd or Ruby, so mark these tests as pending until decide it.
Docs Changes:
N/A
Release Note:
N/A