Backport (v1.16): in_tail: Manage tail watchers that are rorate_wait state too (#4334) - #4427
Merged
Conversation
After a tail watcher transitions to `rotate_wait` state, the `rotate_wait` timer is no longer managed by in_tail, it might cause unexpected behaviour. e.g.) * It's never unwatched when shutdown occurs before `rotate_wait` passed. * Needless `rotate_wait` timers are executed when it detects more rotations. This patch fixes such unexpected behaviour. Note: The comment about `detach_watcher` was added in 76f246a. At that time, closing was done by event-loop. Now, the situation is completely different, so it should be removed. --------- Signed-off-by: Takuro Ashie <ashie@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
Member
|
Hmm, it would be better to disable CI on Ruby head (by another PR) since it's never succeeded anymore. |
ashie
approved these changes
Mar 8, 2024
Contributor
Author
|
Oh, this is not included in v1.16 branch! We should backport this, right? |
Member
Yup |
Member
|
https://github.com/fluent/fluentd/actions/runs/8201645424/job/22430795800?pr=4427 It seems that sometimes it occurs only on macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rorate_waitstate too #4334