Skip to content

ci: do not show test detail immediately - #4452

Merged
kenhys merged 1 commit into
fluent:masterfrom
kenhys:no-show-detail
Mar 27, 2024
Merged

ci: do not show test detail immediately#4452
kenhys merged 1 commit into
fluent:masterfrom
kenhys:no-show-detail

Conversation

@kenhys

@kenhys kenhys commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

N/A

What this PR does / why we need it:

TESTOPTS=-v shows running test and the result.
If something weird happen, it show error immediately.

As rake task executes many tests, so it may be better to delay showing test details later.

NOTE: --progress-style=fault-only helps you to focus on failure, but it is inconvenient when test case has stalled.

Docs Changes:

N/A

Release Note:

N/A

TESTOPTS=-v shows running test and the result.
If something weird happen, it show error immediately.

As rake task executes many tests, so it may be better to
delay showing test details later.

NOTE: --progress-style=fault-only helps you to focus on
failure, but it is inconvenient when test case has stalled.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Comment thread .github/workflows/test-ruby-head.yml

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! I want this!!

@kenhys

kenhys commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

Error detail is shown before Omission:

image

@kenhys
kenhys merged commit 5ffe67e into fluent:master Mar 27, 2024
@kenhys
kenhys deleted the no-show-detail branch March 27, 2024 08:42
@daipom

daipom commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Perfect!! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants