Skip to content

Backport(v1.16): config: yaml_parser: Handle $log_level element for special case (#4482) - #4486

Merged
ashie merged 1 commit into
v1.16from
v1.16-backport-4482
Jun 7, 2024
Merged

Backport(v1.16): config: yaml_parser: Handle $log_level element for special case (#4482)#4486
ashie merged 1 commit into
v1.16from
v1.16-backport-4482

Conversation

@daipom

@daipom daipom commented May 7, 2024

Copy link
Copy Markdown
Contributor

Backported from 236d87d. (#4482)

@ashie

ashie commented May 7, 2024

Copy link
Copy Markdown
Member

Hmm, CI is failed due to a change of dependent gem. It seems that console gem is needed pinned.

@daipom

daipom commented May 7, 2024

Copy link
Copy Markdown
Contributor Author

Hmm, CI is failed due to a change of dependent gem. It seems that console gem is needed pinned.

I have made the issue for this:

We should resolve this first.

@daipom

daipom commented May 7, 2024

Copy link
Copy Markdown
Contributor Author

For console v1.25, we need to consider #4487

For console v1.24, we need to backport #4477.

@daipom
daipom force-pushed the v1.16-backport-4482 branch from 26d5a3e to 2ff5905 Compare May 29, 2024 01:28
Backported from 236d87d.

---

This is because `@log_level` is invalid for YAML.
Instead, we should interpret $log_level as `@log_level` on YAML parser.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@daipom
daipom force-pushed the v1.16-backport-4482 branch from 2ff5905 to 2020531 Compare June 7, 2024 09:06
@ashie
ashie merged commit 00ab6e8 into v1.16 Jun 7, 2024
@ashie
ashie deleted the v1.16-backport-4482 branch June 7, 2024 23:44
@daipom daipom added this to the v1.16.6 milestone Aug 15, 2024
daipom added a commit that referenced this pull request Aug 20, 2024
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants