Skip to content

Backport(v1.16): Fix a failed test of ConsoleAdapter (#4477) - #4489

Closed
daipom wants to merge 1 commit into
v1.16from
v1.16-backport-4477
Closed

Backport(v1.16): Fix a failed test of ConsoleAdapter (#4477)#4489
daipom wants to merge 1 commit into
v1.16from
v1.16-backport-4477

Conversation

@daipom

@daipom daipom commented May 7, 2024

Copy link
Copy Markdown
Contributor

Backported from a226e28. (#4477)

Backported from a226e28.

---

Follow the change of the log format as of console v1.24.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@daipom

daipom commented May 7, 2024

Copy link
Copy Markdown
Contributor Author

This fixes the CI failures for Ruby v3.0. (related to console gem v1.24)

For Ruby v3.1, 3.2, and 3.3, we need to consider #4487. (related to console gem v1.25)

@daipom

daipom commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

The following PR will solve this issue on v1.16, so we don't need this backport.

@daipom daipom closed this May 28, 2024
@daipom
daipom deleted the v1.16-backport-4477 branch May 29, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants