Skip to content

Add logger gem as dependency for Ruby 3.5 - #4589

Merged
daipom merged 1 commit into
fluent:masterfrom
Watson1978:add-logger-gem
Aug 15, 2024
Merged

Add logger gem as dependency for Ruby 3.5#4589
daipom merged 1 commit into
fluent:masterfrom
Watson1978:add-logger-gem

Conversation

@Watson1978

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
logger gem was marked as bundled gem for Ruby 3.5. Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

(Currently, this patch will suppress warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. message.)

Similar with GH-4411

Docs Changes:

Release Note:

logger gem was marked as bundled gem for Ruby 3.5.
Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

(Currently, this patch will suppress `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.` message.)

Similar with fluentGH-4411

Signed-off-by: Watson <watson1978@gmail.com>

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@daipom daipom added this to the v1.17.1 milestone Aug 15, 2024
@daipom
daipom merged commit 7dcfb5f into fluent:master Aug 15, 2024
@Watson1978
Watson1978 deleted the add-logger-gem branch August 15, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants