Use each instead of each_with_index - #4641
Merged
Merged
Conversation
It is trivial, but apparently index is not used at all in this method. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
replace-each-with-index
branch
from
September 20, 2024 06:11
d4d9e22 to
1d2d219
Compare
Contributor
Author
|
This code is not changed since 2014... |
daipom
approved these changes
Sep 20, 2024
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks!
Waiting CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
It is trivial, but apparently index is not used at all in this method.
It does not change internal logic at all.
Docs Changes:
N/A
Release Note:
N/A