Skip to content

test_in_udp: Reduce execution time of message_length_limit test - #4682

Merged
ashie merged 1 commit into
masterfrom
reduce-test-execution-time
Oct 22, 2024
Merged

test_in_udp: Reduce execution time of message_length_limit test#4682
ashie merged 1 commit into
masterfrom
reduce-test-execution-time

Conversation

@ashie

@ashie ashie commented Oct 22, 2024

Copy link
Copy Markdown
Member

Which issue(s) this PR fixes:
N/A

What this PR does / why we need it:
Although it's improved in #4676, it still takes 5 seconds on windows.
It can be reduced more by sending data that doesn't exceed the limit.

  test: message_length_limit:                           .: (1.104855)

Docs Changes:
N/A

Release Note:
N/A

Although it's improved in #4676, it still takes 5 seconds on windows.
It can be reduced more by sending data that doesn't exceed the limit.

```
  test: message_length_limit:                           .: (1.104855)
```

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie
ashie requested review from Watson1978 and daipom October 22, 2024 01:15

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Watson1978 Watson1978 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ashie

ashie commented Oct 22, 2024

Copy link
Copy Markdown
Member Author

A remaining failed test will be handled in another issue or PR:

1) Failure: test: multiple values are set to RUBYOPT(TestFluentdCommand::configured to run 2 workers):
  log doesn't match.

@ashie
ashie merged commit f493f25 into master Oct 22, 2024
@ashie
ashie deleted the reduce-test-execution-time branch October 22, 2024 01:52
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label Nov 29, 2024
@daipom daipom added the CI Test/CI issues label Jan 28, 2025
@daipom daipom added this to the v1.18.0 milestone Jan 28, 2025
@kenhys kenhys modified the milestones: v1.18.0, v1.16.7 Jan 28, 2025
daipom pushed a commit that referenced this pull request Jan 29, 2025
…limit test (#4682) (#4790)

**Which issue(s) this PR fixes**: 

Backport #4682 

**What this PR does / why we need it**: 

Although it's improved in #4676, it still takes 5 seconds on windows. It
can be reduced more by sending data that doesn't exceed the limit.

```
  test: message_length_limit:                           .: (1.104855)
```

**Docs Changes**:

**Release Note**:

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Co-authored-by: Takuro Ashie <ashie@clear-code.com>
@kenhys kenhys added the backported "backport to LTS" is done label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants