test_out_forward: remove unnecessary ack_response_timeout setting - #4685
Merged
Conversation
Seems that timeout setting is short in ack_response_timeout. Seems that It may take some time to receive a ACK response so the process in ack handler has expired and the node is disabled. Signed-off-by: Watson <fujita@clear-code.com>
Watson1978
marked this pull request as ready for review
October 28, 2024 00:51
daipom
self-requested a review
October 28, 2024 06:52
Contributor
|
There are still some unclear points for me: |
Contributor
|
Thanks for this enhancement! Indeed, the timeout is short. How about removing the timeout setting? Both this setting and the following setting would be unnecessary for the tests.
fluentd/test/plugin/test_out_forward.rb Line 662 in f9b0770 How about removing these 2 setting? |
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
changed the title
daipom
pushed a commit
that referenced
this pull request
Jan 29, 2025
…eout setting (#4685) (#4791) **Which issue(s) this PR fixes**: Backport #4685 **What this PR does / why we need it**: Seems that timeout setting is short in ack_response_timeout. Seems that It may take some time to receive a ACK response so the process in ack handler has expired and the node is disabled. This PR will remove unnecessary ack_response_timeout settings for the test **Docs Changes**: **Release Note**: Signed-off-by: Watson <fujita@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Co-authored-by: Watson <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4684
What this PR does / why we need it:
Seems that timeout setting is short in ack_response_timeout.
Seems that It may take some time to receive a ACK response
so the process in ack handler has expired and the node is disabled.
This PR will remove unnecessary ack_response_timeout settings for the test
Docs Changes:
Release Note: