test_cat: use proper protocol in unused_port method - #4686
Merged
Conversation
Watson1978
force-pushed
the
fix-unused_port
branch
from
October 28, 2024 04:33
ff37a08 to
6c1784c
Compare
daipom
self-requested a review
October 28, 2024 07:02
Contributor
|
Thanks, but it should be ref: #4674 (comment) |
Contributor
|
daipom
reviewed
Oct 28, 2024
Signed-off-by: Watson <fujita@clear-code.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: Watson <fujita@clear-code.com>
Watson1978
force-pushed
the
fix-unused_port
branch
from
October 28, 2024 07:44
0fa99e1 to
55b3fdc
Compare
Contributor
Author
|
Thanks! |
Merged
kenhys
pushed a commit
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Watson <fujita@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
This was referenced Jan 29, 2025
Closed
kenhys
pushed a commit
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Watson <fujita@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom
added a commit
that referenced
this pull request
Jan 29, 2025
**Which issue(s) this PR fixes**: Backport #4686 **What this PR does / why we need it**: Fixes an issue where an inappropriate protocol was specified in the unused_port method. See #4674 (comment) **Docs Changes**: **Release Note**: Signed-off-by: Watson <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Watson <watson1978@gmail.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4674
What this PR does / why we need it:
Fixes an issue where an inappropriate protocol was specified in the
unused_portmethod.See #4674 (comment)
Docs Changes:
Release Note: