test_in_tail: fix flaky tests for file rotation - #4710
Merged
Conversation
daipom
reviewed
Nov 19, 2024
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
fix-test_in_tail
branch
from
November 20, 2024 00:29
ff454c2 to
8880cb6
Compare
Watson1978
marked this pull request as ready for review
November 20, 2024 00:30
kenhys
pushed a commit
that referenced
this pull request
Jan 29, 2025
* test_in_tail: fix flaky tests for file rotation Signed-off-by: Shizuo Fujita <fujita@clear-code.com> * test_in_tail: remove unnecessary inode assertions Signed-off-by: Shizuo Fujita <fujita@clear-code.com> --------- Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom
pushed a commit
that referenced
this pull request
Jan 29, 2025
… (#4795) **Which issue(s) this PR fixes**: Backport #4710 **What this PR does / why we need it**: This PR will fix unstable tests. * test_in_tail: fix flaky tests for file rotation * test_in_tail: remove unnecessary inode assertions **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Watson <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4707
What this PR does / why we need it:
This PR will fix unstable tests.
Docs Changes:
Release Note: