Skip to content

ci: use latest rubygems again for Ruby 3.1 on windows - #4750

Merged
daipom merged 1 commit into
fluent:masterfrom
kenhys:use-latest
Dec 27, 2024
Merged

ci: use latest rubygems again for Ruby 3.1 on windows#4750
daipom merged 1 commit into
fluent:masterfrom
kenhys:use-latest

Conversation

@kenhys

@kenhys kenhys commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

Fixes #

What this PR does / why we need it:

It seems that it fixes failure with Ruby 3.1 on windows.

   undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168

Docs Changes:

N/A

Release Note:

N/A

It seems that it fixes failure with Ruby 3.1 on windows.

   undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
It appears that Ruby 3.1 on Windows has the same issue

@daipom
daipom merged commit 6d4e0d0 into fluent:master Dec 27, 2024
@daipom daipom added this to the v1.19.0 milestone Jan 28, 2025
@daipom daipom added the CI Test/CI issues label Jan 28, 2025
kenhys added a commit that referenced this pull request Jan 29, 2025
**Which issue(s) this PR fixes**:

Backport #4750

**What this PR does / why we need it**:

It seems that it fixes failure with Ruby 3.1 on windows.

```
   undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168
```

NOTE: Initially introduced by #4681, then reverted in #4746.
Thus, it's a side-effect of #4760.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@daipom daipom added the backport to v1.16 We will backport this fix to the LTS branch label Jan 29, 2025
daipom pushed a commit that referenced this pull request Jan 29, 2025
…#4750) (#4803)

**Which issue(s) this PR fixes**:

Backport #4750

**What this PR does / why we need it**:

It seems that it fixes failure with Ruby 3.1 on windows.

```
   undefined method `ignored?' for #<Gem::Specification:0x000001dccaf43168
```

NOTE: Initially introduced by #4681, then reverted in #4746. Thus, it's
a side-effect of #4746.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys pushed a commit that referenced this pull request Jan 29, 2025
**Which issue(s) this PR fixes**: 
None.

**What this PR does / why we need it**: 
Remove `latest` setting for `rubygems`.
We added it for Ruby 3.1 on Windows (#4750).
We have already dropped Ruby 3.1, so we don't need it anymore.

**Docs Changes**:
Not needed.

**Release Note**: 
Not needed.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@kenhys
kenhys deleted the use-latest branch February 28, 2025 02:51
@daipom daipom added the backported "backport to LTS" is done label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.16 We will backport this fix to the LTS branch backported "backport to LTS" is done CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants