Skip to content

Backport(v1.16) tests: fix unused_port (PR#4675) - #4788

Merged
daipom merged 1 commit into
v1.16from
backport-pr4675
Jan 29, 2025
Merged

Backport(v1.16) tests: fix unused_port (PR#4675)#4788
daipom merged 1 commit into
v1.16from
backport-pr4675

Conversation

@kenhys

@kenhys kenhys commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

Fixes #4674

What this PR does / why we need it:

It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.

This patch will obtain and use unused ports appropriately for each protocol.

Backported from #4675

Docs Changes:

Release Note:

It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.
This patch will obtain and use unused ports appropriately for each protocol.

See #4675

Signed-off-by: Watson <fujita@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys added this to the v1.16.7 milestone Jan 28, 2025
@kenhys

kenhys commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

Backport with:

git switch -c backport-pr4675 --track origin/v1.16
git cherry-pick 0634bd5e4488c2a11895beaf60e341074914ff82

@kenhys
kenhys requested a review from daipom January 28, 2025 09:04

@daipom daipom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom
daipom merged commit 0c5b764 into v1.16 Jan 29, 2025
@daipom
daipom deleted the backport-pr4675 branch January 29, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants