[WIP] checks-run: remove duplicate coverage.rc file creation - #682
[WIP] checks-run: remove duplicate coverage.rc file creation#682cmoussa1 wants to merge 2 commits into
coverage.rc file creation#682Conversation
coverage.rc file creationcoverage.rc file creation
f026d83 to
cbd42c9
Compare
|
Did this end up being a problem? I thought |
|
No, not a problem. I opened this PR mostly as an experiment to see if removing the duplicate |
|
I wonder if this error is the problem: I'm not sure why the extra |
cbd42c9 to
b596c9b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 26 26
Lines 2185 2185
=======================================
Hits 1838 1838
Misses 347 347 🚀 New features to boost your workflow:
|
a771978 to
027fe56
Compare
b29ae65 to
e6fe758
Compare
Problem: checks_run.sh has two instances of creating a coverage.rc file. Remove the duplicate creation of coverage.rc.
Problem: The pycotap/ directory is mistakenly duplicated both inside the t/ directory and inside the t/python/tap/ directory. It should follow flux-core's structure, which just contains pycotap/ inside of t/python/tap/. Remove the duplicate directory. Update the PYTHONPATH variable in t/Makefile.am to account for the change. Add a PY_LOG_DRIVER variable to t/Makefile.am to match flux-core's t/Makefile.am.
d8bfa8f to
643e4da
Compare
Problem
checks_run.shhas two instances of creating acoverage.rcfile.This PR removes the duplicate creation of
coverage.rc. Also looking to see if this might fix the missing Python bindings coverage for this repository.