rfc13: clarify version handshake - #548
Merged
Merged
Conversation
Problem: hydra from MPICH 5 cannot bootstrap Flux. RFC 13's Version Negotiation section states that the server's response dictates the protocol version that will be used, but this does not match MPICH behavior as hashed out in pmodels/mpich#7751. Correct the description, and rename that section to "Version Handshake". Update a reference to negotiation in the early mention of PMI-2. The new description matches how hydra behaves now that PMI 1.2 is available in MPICH 5, and is also compatible with Slurm's historical behavior.
|
|
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 25 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: hydra from MPICH 5 cannot bootstrap Flux.
RFC 13's Version Negotiation section states that the server's response dictates the protocol version that will be used, but this does not match MPICH behavior as hashed out in pmodels/mpich#7751.
Correct the description, and rename that section to "Version Handshake". Update a reference to negotiation in the early mention of PMI-2.
The new description matches how hydra behaves now that PMI 1.2 is available in MPICH 5, and is also compatible with Slurm's historical behavior.