rfc13: sync wire protcol ABNF with MPICH protocol specs - #549
Merged
Conversation
garlick
changed the title
|
|
Problem: RFC 13 does not cite the (new?) MPICH wire protocol definition files. Add citations. Assisted-by: Claude:claude-opus-4.8
Problem: the RFC 13 abort ABNF disagrees with the MPICH wire protocol definition files on three points: 1. it fails to define the required abort "exitcode" attribute 2. it fails to define the optional abort "message" attribute 3. it defines an abort response that should not exist Fix the abort ABNF. Assisted-by: Claude:claude-opus-4.8
Problem: the RFC 13 get_result ABNF (the response to the KVS get) omits an optional "found" attribute described by the MPICH protocol definition files. Update ABNF and add some description to the Error Handling section. Assisted-by: Claude:claude-opus-4.8
Problem: RFC 13 requires the kvsname key on put and get, but the MPICH protocol definition files show it as optional. Make kvsname optional. Assisted-by: Claude:claude-opus-4.8
|
|
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 14 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: RFC 13 contains a few minor errors in its wire protocol ABNF when compared to the MPICH protocol specs.
The MPICH protocol specification files should be considered authoritative. Fix the bugs and add citations to those files.