fix: attempt to fix memory leaks by recreating kernels when needed#145
Open
Saschl wants to merge 1 commit intoflybywiresim:mainfrom
Open
fix: attempt to fix memory leaks by recreating kernels when needed#145Saschl wants to merge 1 commit intoflybywiresim:mainfrom
Saschl wants to merge 1 commit intoflybywiresim:mainfrom
Conversation
tracernz
reviewed
Feb 5, 2026
| this.uploadWorldMapToGPU.output[1] !== worldHeight | ||
| ) { | ||
| if (this.uploadWorldMapToGPU !== null) this.uploadWorldMapToGPU.destroy(); | ||
| this.uploadWorldMapToGPU = this.createUploadWorldMapToGPUKernel().setOutput([worldWidth, worldHeight]); |
Member
There was a problem hiding this comment.
You could pass the output size array into the kernel creation functions, and put it in the output property of the kernel settings object to avoid calling setOutput altogether.
tracernz
reviewed
Feb 5, 2026
Comment on lines
+72
to
+81
| private createUploadWorldMapToGPUKernel(): IKernelRunShortcut { | ||
| return this.gpu.createKernel(uploadTextureData, { | ||
| argumentTypes: { texture: 'Array', width: 'Integer' }, | ||
| dynamicArguments: true, | ||
| dynamicOutput: false, | ||
| pipeline: true, | ||
| immutable: false, | ||
| tactic: 'speed', | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
e.g.
Suggested change
| private createUploadWorldMapToGPUKernel(): IKernelRunShortcut { | |
| return this.gpu.createKernel(uploadTextureData, { | |
| argumentTypes: { texture: 'Array', width: 'Integer' }, | |
| dynamicArguments: true, | |
| dynamicOutput: false, | |
| pipeline: true, | |
| immutable: false, | |
| tactic: 'speed', | |
| }); | |
| } | |
| private createUploadWorldMapToGPUKernel(output: [number, number]): IKernelRunShortcut { | |
| return this.gpu.createKernel(uploadTextureData, { | |
| argumentTypes: { texture: 'Array', width: 'Integer' }, | |
| dynamicArguments: true, | |
| dynamicOutput: false, | |
| pipeline: true, | |
| immutable: false, | |
| tactic: 'speed', | |
| output, | |
| }); | |
| } |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed by @frayien and @tracernz creating a GPU kernel with dynamicOutput might create memory leaks each time "setOutput" is called. This PR disables dynamicOutput and recreates the kernels if the output sizes change.