chore(env): added setup.sh and readme updates for working build and run#79
Open
mickster04 wants to merge 3 commits intoflybywiresim:mainfrom
Open
chore(env): added setup.sh and readme updates for working build and run#79mickster04 wants to merge 3 commits intoflybywiresim:mainfrom
mickster04 wants to merge 3 commits intoflybywiresim:mainfrom
Conversation
Member
|
Is this stale? @mickster04 |
Contributor
Author
|
I dunno what else I could do here? |
Member
Well there's a pending change. Once you amend that I can approve it and get it merged. |
Lucky38i
changed the title
Lucky38i
changed the title
Contributor
Author
|
Is that resolved now? I don't know what pending change you're referring to otherwise sorry. |
Member
Move the setup.sh into the scripts folder please. |
Contributor
Author
|
Good catch, also I didn't do a branch, I hope it's ok for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some issues getting the build working using readme,
@Saschl helped identify the extra steps needed, This change updates the readme to point to a sh file that can be run to do all the setup steps. this in itself is simple enough and can be run command by command manually as needed.
I also added further instructions on how to install and use an older Node version.