Repository navigation
Remove 30 placeholder tests that asserted nothing - #847
Conversation
Every one was #[ignore]d with a todo! or unimplemented! body. They read as coverage of copy-on-write overlays, privacy and claims, merge regimes, open portals and bucket footprints, and checked none of it. - parallel_cow.rs, parallel_privacy.rs and parallel_merge.rs held only placeholders (24) and are deleted. - Four placeholders and their plan comments leave parallel_openportal_rules.rs, along with the unimplemented lint allowance added for them; two leave parallel_footprints.rs. Each test name and its stated intent is recorded on #814. Fixes #814. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9df913d563
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
Removes every
#[ignore]d test inwarp-corewhose body wastodo!orunimplemented!(audit finding #814). They read as coverage and checked nothing.parallel_cow.rsparallel_privacy.rsparallel_merge.rsparallel_openportal_rules.rsparallel_footprints.rsThe
clippy::unimplementedallowance added toparallel_openportal_rules.rsfor these goes too, with the orphaned plan comments.Nothing is lost: each test's name and stated intent is recorded verbatim on #814.
parallel_determinism.rskeeps one ignored test that has a real body; it is not a placeholder.Evidence (guarded container)
warp-coreintegration tests with default features: 1,418 pass. Thedelta_validatelane for the two edited files: 22 pass.cargo fmt --check.Fixes #814.
🤖 Generated with Claude Code