Repository navigation
Import: fail closed instead of staging against the default worldline (#892) - #899
Conversation
…892) dispatch_intent routed every witnessed-suffix import intent to the kernel's default worldline, ignoring the request's receiving worldline, and the import rule recorded Staged without the bundle and basis checks import_suffix performs. Evidence was produced under the wrong causal coordinate. Until comparable-basis transport exists (flyingrobots/continuum#80) and the import is dispatched to its named receiving worldline, dispatch refuses import intents with NOT_SUPPORTED after validating the envelope. Nothing is ingested, staged or attributed; a malformed envelope is still INVALID_INTENT. Witness import_suffix_dispatch_fails_closed_until_transport_exists fails on main (the import was accepted and staged) and passes now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Closes #892. Part of #891 (Paper VII conformance remediation); the owner ruling there classifies this as incorrect, not incomplete.
What changes
dispatch_intentrouted every witnessed-suffix import intent toDefaultWriter { self.default_worldline }, ignoring the request'starget_worldline_id. The import rule then recordedStagedwithout the bundle and basis checksimport_suffixperforms, so a forged bundle was staged where the library obstructs it. That is evidence under the wrong causal coordinate.Per the ruling, the wired import now fails closed. After validating the envelope,
dispatch_intentreturnsNOT_SUPPORTEDand ingests, stages and attributes nothing. It never substitutes the default worldline. A malformed envelope is stillINVALID_INTENT. The library evaluator is unchanged and is not reachable from dispatch.This does not implement transport or import. It is gated on flyingrobots/continuum#80 (comparable-basis transport), per the ruling.
Witness (guarded worker)
import_suffix_dispatch_fails_closed_until_transport_exists: dispatch is refused withNOT_SUPPORTED; after running the scheduler, the head has not advanced, and neither the ingress event nor a staged result node exists.main's dispatch, same testIt replaces
import_suffix_intent_enters_ingress_and_scheduler, which asserted the misattributed staging. Full chain: featured 1861, default 1381 and workspace 981 tests pass; warp-wasm 55 pass; clippy (all six configurations, plus warp-wasm all targets), fmt, rustdoc and docs-model checks are clean.Documentation
docs/architecture/continuum-transport.md(current status of the import flow), CHANGELOG (Fixed).🤖 Generated with Claude Code