Skip to content

Fix Rust 1.99 Clippy lints in the native harness - #76

Open
flyingrobots wants to merge 1 commit into
mainfrom
fix/rust-1-99-clippy
Open

flyingrobots wants to merge 1 commit into
mainfrom
fix/rust-1-99-clippy

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

What changed

Fixes the seven Clippy errors that Rust 1.99 reports in examples/native-render-everywhere. CI installs unpinned stable Rust, so these new lints block every PR, including #74.

  • chunks_exact_to_as_chunks: four constant-size chunks_exact calls now use as_chunks::<4>(). A partial last chunk is still dropped, so pixel iteration is unchanged.
  • missing_const_for_fn: has_windows_drive_prefix is now a const fn in both files.
  • assert_is_empty: the smoke test uses assert_ne!, so a failure shows the value.

Validation

cargo fmt --check -p native-render-everywhere
cargo clippy -p native-render-everywhere --all-targets -- -D warnings
cargo test -p native-render-everywhere

All pass locally on Rust 1.98.1. Rust 1.99 lints are verified by CI.

Closes #75

Replace constant-size chunks_exact calls with as_chunks, make
has_windows_drive_prefix a const fn, and use assert_ne! for the smoke
output check. as_chunks drops a partial last chunk, the same as
chunks_exact, so pixel iteration is unchanged.

Closes #75
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-08T09:35:28.662259Z
We couldn’t complete this review. Comment @codex review to try again.
f040cc3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 940336bd-424e-4d22-8ec9-ab56a255f6bf
Commits

Reviewing files that changed from the base of the PR and between f68160f and f040cc3.

Files selected for processing: 2

  • examples/native-render-everywhere/src/bunny.rs
  • examples/native-render-everywhere/src/main.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad Code™: Rust 1.99 Clippy lints break CI on main

1 participant