Repository navigation
Fix Rust 1.99 Clippy lints in the native harness - #76
flyingrobots wants to merge 1 commit into
Conversation
Replace constant-size chunks_exact calls with as_chunks, make has_windows_drive_prefix a const fn, and use assert_ne! for the smoke output check. as_chunks drops a partial last chunk, the same as chunks_exact, so pixel iteration is unchanged. Closes #75
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
What changed
Fixes the seven Clippy errors that Rust 1.99 reports in
examples/native-render-everywhere. CI installs unpinned stable Rust, so these new lints block every PR, including #74.chunks_exact_to_as_chunks: four constant-sizechunks_exactcalls now useas_chunks::<4>(). A partial last chunk is still dropped, so pixel iteration is unchanged.missing_const_for_fn:has_windows_drive_prefixis now aconst fnin both files.assert_is_empty: the smoke test usesassert_ne!, so a failure shows the value.Validation
cargo fmt --check -p native-render-everywhere cargo clippy -p native-render-everywhere --all-targets -- -D warnings cargo test -p native-render-everywhereAll pass locally on Rust 1.98.1. Rust 1.99 lints are verified by CI.
Closes #75