Repository navigation
fix: thread-unsafe global state in id.c - #131
Merged
Merged
Conversation
Replace race-prone boolean flag with pthread_once for SipHash key initialization. This ensures the key is initialized exactly once even with concurrent access. - Replace g_siphash_key_initialized flag with pthread_once_t - Use pthread_once() to guarantee single initialization - Add pthread to LDFLAGS in Makefile - Free error on fallback path to prevent memory leak Fixes TODO #1 from TASKLIST.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
g_siphash_key_initializedflag withpthread_once_tpthread_once()to guarantee single initializationTest Plan
test_id_thread_safety) verifies concurrent access🤖 Generated with Claude Code