Repository navigation
chore(core/migration): remove legacy src/ duplicates; convert include/gitmind.h to pure umbrella; flatten CLI path to apps/cli/ - #165
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(core/migration): finish core migration cleanup\n\nSummary\n- Remove legacy sources under src/: edge/edge.c, edge/attributed.c, util/sha.c, util/gm_mem.h (superseded by core)\n- Convert include/gitmind.h to a pure umbrella that aggregates core public headers, no duplicate typedefs or prototypes\n- Flatten CLI path: apps/cli/cli/* → apps/cli/* (no build target change yet)\n\nRationale\n- Unblocks Sprint 1 CLI build by eliminating duplicate type definitions between the umbrella and namespaced core headers\n- Reduces confusion by removing legacy src/ code paths that are no longer built\n- Aligns tree layout with docs: apps/ contains CLI; core/ holds library and public headers\n\nTesting\n- Local Docker build/tests (Meson/Ninja) all green (14/14 unit tests)\n- No CLI build in Meson yet (separate PR will add CLI target + E2E wiring)\n\nFollow-ups\n- Add Meson CLI target now that umbrella is clean; wire E2E tests to CI\n- Tidy passes unaffected; gauntlet unchanged\n\nHousekeeping\n- build_* folders remain gitignored; safe to delete locally as they are ephemeral\n\nRequested\n- Auto-merge once checks and CodeRabbit approvals are satisfied
Summary by CodeRabbit
Refactor
New Features
Bug Fixes
Tests
Chores / Removed