Repository navigation
Add modal explorer navigation, filtering, and file previews - #342
Conversation
flyingrobots
added
the
work-in-progress
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
flyingrobots
changed the title
flyingrobots
removed
the
work-in-progress
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 055795d94a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
flyingrobots
added
the
work-in-progress
flyingrobots
changed the title
flyingrobots
removed
the
work-in-progress
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44d28cb964
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
After following .. above the startup workspace, entries fell back to their absolute path, so ancestor directory names matched every entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ceee07c805
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Explorer previews of open buffers use the text-authority reading instead of the editor projection, which can be a stale opening window, and report truncation from the reading total. A reading that misses the file head falls back to reading the file. - The terminal input stream flushes any unfinished escape sequence after the escape delay and ends a CSI prefix at a control byte, so Ctrl+C and Escape are no longer swallowed after ESC[. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #336 (Leader settings), #339 (static title screen), and #342 (explorer search). quality-baseline.json takes main's lower title-screen spec budget and keeps this branch's removal of the law-cycle entry. title-screen.md folds the freeze reference into main's Standalone Scene Tools section, 0160 links the moved freeze doc, and the freeze doc now says the engine and assets (reachable only through the title tools) are frozen, since the title screen itself is a static logo.
Files previously opened with its filter always editing, so printable navigation keys became query text. Ctrl+B now opens navigation mode; j/k and arrows select results.
/or an input click enters filter editing. Esc/Enter returns to navigation while keeping the query; Esc in navigation closes the drawer.Pointer hover highlights a row without selecting or reading a preview. A click selects, with a distinct selection background and contrast-adjusted foreground. Selecting a file shows a labelled read-only preview in the main viewer while focus remains on Files. Enter explicitly opens it through native Echo and focuses the editor. Closing or leaving Files restores the existing editor.
Previews prefer current open-buffer projections, preserving unsaved text. Filesystem reads are capped at 64 KiB and 200 lines, report binary/unavailable/truncated states, and cannot block on named pipes. Entry/request identity rejects stale results. No preview creates an Echo buffer, edits, saves, or persists a cache. Fuzzy search covers loaded names and relative paths, with stable order; broader semantic/Graft search remains deferred to #341.
Validation:
npm run checkpassed (855 JavaScript tests passed, 12 existing skips; all 99 native tests passed), quality has no regressions, and shard coverage includes 134 specs. Twenty-five focused tests cover modality, pointer identity, preview preservation/staleness, bounded readers, theme contrast, portable Windows paths, and the production Unicode/modified-arrow/hover decoder through the Bijou event bus. Real native PTYs at 100×32 and 60×16 confirmed selection, hover, previews, Unicode filtering, modified Alt+Up, and explicit Echo opening. Final-head full CI passed all 12 jobs.The prior Unicode, Windows-path, and Alt+Up review findings are fixed and resolved. Design and retrospective:
docs/design/0161-file-explorer-search.md. Canonical preview ownership is recorded indocs/jim-component-ownership.md.Stacked on #339 (
feature/static-title-screen); merge that prerequisite first. Neither PR has been merged.Closes #340.