Repository navigation
README: show the three built-in scenes, with the reference scene as the hero image (#180) - #268
Conversation
…he hero image Adds lossless re-encodings of Lumen's 1280x720, 64 spp, seed 0 renders under docs/images/ (2.98 MB in all; each decodes to the pixels of the stated image hash), a README that opens with what Lumen does and the reference scene, .gitattributes entries so no filter touches the images, and the changelog entry. Issue: #180 Agent-Session: 6d1f3b52-7c0e-4b8a-9a41-180c0ffee180 Agent-Tool: Claude Code
|
WIP: three renders re-encoded and byte-checked, README, .gitattributes, changelog and scenes.md updated, doc-links passes in the container. Next: wait for CI, then rewrite the description. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
CI is green on the head commit; description holds the evidence and test plan. Out of draft. |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Closes #180
Agent-written documentation, not yet human-reviewed.
What changed
docs/images/: three lossless re-encodings (macOSsips -s format png) of Lumen's own renders (lumen render --scene S --width 1280 --height 720 --samples 64 --seed 0, run in the container, exported withdevrun --export).README.md: first sentence says what Lumen does, then names Geordi and Bunny; the reference scene is the hero image; a section shows Fixed Point and the canyon, each with alt text, the render command, the image hash and the size; plaincargofor all three,make demofor maintainers withdevrun..gitattributes:docs/images/*.png binary -filter.CHANGELOG.md: the Documentation entry under Unreleased now describes the images (README: show the three built-in scenes, with the reference scene as the hero image #180).docs/reference/scenes.md: the canyon section said no image of it was in the repository; it now links to the README.docs/tutorial.md(its 320 by 180 first image is a different render),docs/README.md, ADR 0009.Evidence
Lumen's report (
sceneandimagelines), and the committed file decoded by a standard-library Python script (zlib, all five PNG filter types) to raw RGBA8:sceneimage(SHA-256 of decoded RGBA8)lumen-reference-scene/47d68fa3a...1700a6elumen-fixed-point-scene/286cdfd58...fb153lumen-canyon-scene/11bd910dc...56446(Full hashes are in the README.) The decoded hash of each committed file equals the
imagehash Lumen printed; the renders were run twice and gave the same hashes.sipsadded onlysRGBandeXIf(dimensions only) chunks; pixels are unchanged.cargo run --locked -q -p xtask -- doc-linksin the container: 29 pages, 0 broken links;Gates / doc linksgreen on CI.Test plan
cargo run --release -p lumen -- render --scene canyon --width 1280 --height 720 --samples 64 --out canyon.png(likewisereference,fixed-point) and compare theimageline with the README.Not verified