Repository navigation
A JSON reader that keeps numbers as text (#211) - #271
flyingrobots wants to merge 2 commits into
Conversation
The entry says what the reader will be, so the pull request opens with its contract written down. Issue: #211 Agent-Session: 3f0c1b7e-6a52-4d1e-9a4c-211a0b5e7c10 Agent-Tool: Claude Code
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Parser, scanner, limits, errors and a first unit-test file. Three position tests have hand-derived expectations that disagree with the reader and are not yet adjudicated. conformance.rs and generated.rs are placeholders. Issue: #211 Agent-Session: 3f0c1b7e-6a52-4d1e-9a4c-211a0b5e7c10 Agent-Tool: Claude Code
|
Handoff (paused) Done (commit 461f4f9, pushed): Not done: the conformance table (JSONTestSuite y/n/i categories, written by hand, source noted), the generated round trip with an independent writer, number-token generation and malformed-number tests, the corpus replay, the library reference table and section (a test requires every root export there), the evidence-map row, clippy/fmt, the full gate, the PR description. Nothing has been run beyond Test state: 17 pass, 3 fail. The failures are my hand-derived expectations in tests.rs, not yet adjudicated against the contract. (a) Next step: fix those three expectations, then write the conformance and generated tests, the docs and the evidence row, then run the gate. Command: python3 ~/git/devcontainers/bin/devrun lumen ~/git/lumen-211 --worktree --cpus 4 --memory 8g --timeout 2400 -- cargo test --locked -p lumen --lib json Uncommitted: nothing. Open questions: none; the scene ADR (#186) and an ADR for the reader are left to the coordinator. |
Closes #211
Work in progress: a JSON reader in the
lumencrate (modulejson, re-exported at the crate root likewrite_png). Description to be rewritten before the pull request leaves draft.