Repository navigation
ADR 0016: all graphics in Bunny, the integrators included - #276
Draft
flyingrobots wants to merge 4 commits into
Draft
flyingrobots wants to merge 4 commits into
flyingrobots wants to merge 4 commits into
Conversation
Extends ADR 0011 to integrators, mesh preparation and pixel-deciding image filters; Lumen keeps scenes, running a render and proving it. Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91 Agent-Tool: Claude Code
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…0 and 0012 Review of #276: the diffuse integrators already have identities; the rule now separates choosing inputs from defining algorithms; debug views and image decoding are explicit exceptions; the migration gate covers radiance, ray outcomes, errors and API, not only image hashes. Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91 Agent-Tool: Claude Code
Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91 Agent-Tool: Claude Code
Owner
Author
|
Review addressed in 26ddb18 and d733409:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the maintainer's 2026-11-17 decision: every computation that decides how light or geometry behaves, integrators included, is a Bunny contract. Extends ADR 0011. Moves
lumen-path/1(#203) to a Bunny integrator; the diffuse integrators move only when a Bunny integrator reproduces their golden hashes bit for bit.Documentation only. Agent-written; not yet human-reviewed.
Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91
Agent-Tool: Claude Code