Skip to content

ADR 0016: all graphics in Bunny, the integrators included - #276

Draft
flyingrobots wants to merge 4 commits into
mainfrom
docs/adr-graphics-boundary
Draft

flyingrobots wants to merge 4 commits into
mainfrom
docs/adr-graphics-boundary

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Records the maintainer's 2026-11-17 decision: every computation that decides how light or geometry behaves, integrators included, is a Bunny contract. Extends ADR 0011. Moves lumen-path/1 (#203) to a Bunny integrator; the diffuse integrators move only when a Bunny integrator reproduces their golden hashes bit for bit.

Documentation only. Agent-written; not yet human-reviewed.

Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91
Agent-Tool: Claude Code

Extends ADR 0011 to integrators, mesh preparation and pixel-deciding
image filters; Lumen keeps scenes, running a render and proving it.

Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91
Agent-Tool: Claude Code
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…0 and 0012

Review of #276: the diffuse integrators already have identities; the
rule now separates choosing inputs from defining algorithms; debug views
and image decoding are explicit exceptions; the migration gate covers
radiance, ray outcomes, errors and API, not only image hashes.

Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91
Agent-Tool: Claude Code
Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91
Agent-Tool: Claude Code
@flyingrobots

Copy link
Copy Markdown
Owner Author

Review addressed in 26ddb18 and d733409:

  • MUST 1: the context now acknowledges lumen-diffuse-path/1 and lumen-smooth-diffuse-path/1 and their provenance; the motivation is implementation ownership and reuse. The rejected-alternatives row is corrected too.
  • MUST 2: debug views (ADR 0010) and image decoding (ADR 0012) are explicit exceptions, with reasons; both ADRs get a dated clarification. The rule now separates choosing inputs from defining algorithms.
  • SHOULD 1: the migration gate lists radiance, ray outcomes, errors, tracer behaviour and API besides image bytes; traversal work is separated out; the independent oracle stays independent.
  • SHOULD 2-5: a small Bunny trait (observers can't steer sampling; ADR 0002's provenance scope unchanged); pbrt is a comparison, not the rule; the ADR: materials and path depth - mirror, GGX metal, glass, and a bounded path #185 sampling rule belongs to the integrator contract; the changelog says nothing is built; the Bunny README update is noted for the first integrator task.
  • The tone curve now moves with the diffuse integrators. That wasn't raised; I found it while checking.

… per ADR 0012

Second review of #276: TONE_CURVE only selects bunny-tone-srgb/1; the
JPEG standard leaves IDCT precision and upsampling open, which is why
lumen-jpeg-decode/1 fixes them; #203 is mirror first.

Agent-Session: 6a7d96a7-b8fe-4679-adfc-846b26ff1c91
Agent-Tool: Claude Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant