Avoid dropping null byte in format string#4732
Open
user202729 wants to merge 1 commit intofmtlib:mainfrom
Open
Avoid dropping null byte in format string#4732user202729 wants to merge 1 commit intofmtlib:mainfrom
user202729 wants to merge 1 commit intofmtlib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider
Both ought to raise a compile-time error because of missing format argument, but before this change, only the second one will. This is because previously
sinstead ofstrwas passed in the checking function, which uses the following constructor overloadand drop everything after the null byte.
Also simplify the other constructor since
str's type is alreadystring_view.