Testing notifications - Do not merge #1
Draft
focanag wants to merge 656 commits into
Draft
Conversation
…new site in Oklahoma City.
…s definition for that quantity
…should be using that, rather than the text version.
…er-digit-digit one. (Saves minor wear and tear on MPC servers.) Also, if 'cospar.txt' isn't found, abort; don't just keep going with a zero rotation rate for the earth or other body.
MPC just published the new position of Z84 with an updated position (improved lat/long and corrected elevation).
Updated rovers and details for Z84 taking advantage of the coordinates update
… data. Better to read said partial line and then ignore it.
…talogue code was given in the input file, and fixed there in 2023... but plenty of old copies of the EFCC18 data are out there; this fix ensures they'll work correctly
…ing SR orbits. Needs some thinking through...
…nt, instead of embedding it. Revised version date.
…nput file. 'splash.txt' can now contain comments (and has a few describing what it does and how to change it).
…een. Scopes were concatenated in pseudo-MPECs when only one telescope was supposed to be displayed.
…r, plus several new and renamed 'official' MPC codes
…, comments could be interpreted as translations. Fixed that.
…nds_, and have been for about twelve years. The variable names used confused that point. (With proper handling, 'noise_in_sigmas' should always be 1 anyway. A problem for a subsequent patch.)
…ng sign, we try just doing an atof() on it. It's quite likely the correct value, but simply doesn't follow MPC's rather strict standards on formatting.
ESA's second TBT in Chile became W57 some time ago. Ellipsoid elevation was reported, but it is still published wrong; we will dutifully report it to the MPC. Plus I could not see a typo.
Update rovers.txt - ET2 got MPC code W57 + typo
… are now managed somewhat more sanely. Also added a few obscodes.
…. Duplicates are now fixed. Also, the launch date for ExoMars 2022 has slipped.
…EC 2024-Y07. Corrected the altitudes and clarified the explanations.
Ensure attempt_extensions() rewrites covar.json for the final best_orbit and final included-observation set.
Sync covar.json after reverting to best orbit
…ack/arcseconds cross-track', or 'normalized', as appropriate.
…orbital elements display was usually converted from ecliptic to equatorial twice for geocentric elements.
…sure_config_directory_exists().
We had two functions, fix_tilde() and fix_home_dir(), which did almost exactly the same thing : if a file name began with ~, it was replaced with getenv( "HOME"). Further, both broke if that environment pointer was NULL (which, for the server-based 'fo_serve.cgi', it is). fix_tilde() is now gone and the code won't segfault. Also, fo_serve.cgi now explicitly looks for files in its own directory.
If an ADES RA is, say, 314.15, it may mean the RA is good to 0.01 degree. Or it may be that trailing zeroes were omitted. The latter is quite likely, but you could introduce garbage data if the data in question was actually truncated/rounded. 'Losing' a digit that way will presumably happen one time in ten. So 10% of the time, an observation _may_ not be given its full, correct weight in the solution. I think that's better than introducing the occasional junk observation; if I change my mind, I'll enable the currently #ifdef-fed out code.
For some reason, I put the call to planet_rotation_rate() inside a loop, instead of computing it once and just using that value. It worked, but there's no good reason to do the math three times.
Pointed out by Qicheng Zhang (issue #69).
…arth-fixed (ECEF). This is a somewhat weird system in use by artsat people.
…download a DE file
…o include only terms after a specified point. It also shows numerically differentiated forces, foc checking the analytically determined ones.
…inning of the input file
…you have to reload the original observation set to undo this).
…model, even if none of the magnitudes are N(uclear) or (T)otal.
…; the hope is that they'll get them sorted someday.
…on-DOS/Windows(R) systems. It should only be replaced if it starts with '~/', i.e., it's a for-real directory. Files with names starting with a tilde were also getting changed.
…one consisting solely of '~', should be replaced with $HOME.
list the mean residuals both in arcseconds and normalized.
incorrect units. Pointed out by Man-To Hui. Work remains to be done here. JSON elements don't show delta-V data (entirely) correctly, and sigmas are missing for both that case and for Yarkovsky solutions. The new get_parameter_name() function should enable considerable simplifying of code, and make adding the delta-V-plus-SRP model (and possibly further force models) less difficult. But all other models now produce correct JSON output, including the sigmas.
…international (COSPAR) designations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.