Repository navigation
fix(site): keep the scaffolding out of the shipped page - #42
Merged
Merged
Conversation
The note explaining why Request access points at a personal address was an HTML comment, so it shipped — telling every visitor who viewed source that the hosted product's own contact address does not receive mail yet, and describing where the domain's MX currently points. The other comments in this file are design notes that explain markup and are worth shipping. An operational note about a state that will not survive the week is not, so it becomes a JSX-style comment beside the link, which Astro does not render. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note explaining why
Request accesspoints at a personal address was an HTML comment, so it shipped to the browser — publishing that the hosted product's contact address does not receive mail, and where the domain's MX points.The file's other comments are design notes explaining markup, and those are worth shipping. An operational note about a temporary state is not. It becomes a JSX-style comment beside the link, which Astro does not render.
Verified:
grepfor it in the builtdist/index.htmlreturns 0.