Improve API and Configuration#4
Conversation
- Changed `process_document` signature to `(file_path, settings=None, ...)`. - Allowed `file_path` to be a string. - Exposed `process_document` and `Settings` at the top-level package. - Updated `Settings` to load from environment variables and provided better defaults. - Updated tests to match API changes and added new settings tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add return type annotations to `tests/test_settings.py`. - Combine nested `with` statements in `tests/test_settings.py`. - Fix argument order for `process_document` in `run_ocr.py`.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the API usability and configuration management of the gemini-ocr package. The changes, such as refining the process_document signature, exposing key components at the top level, and enabling configuration from environment variables, are well-implemented. The accompanying test updates and additions are also thorough. My review includes a few suggestions for further refinement, mainly around improving code maintainability by reducing duplication and enhancing the new configuration loading mechanism. Overall, this is a strong contribution that enhances the library's flexibility.
1 participant
This PR addresses several usability improvements and configuration enhancements:
API Changes:
process_documentsignature updated to standard(file_path, settings, ...)order.file_pathnow accepts strings.process_documentandSettingsare now exposed at the top level (from gemini_ocr import process_document).Configuration:
Settingsclass now supports loading from environment variables (e.g.,GEMINI_OCR_PROJECT).Tests:
tests/test_settings.py.