Skip to content

Add gcs support#5

Merged
folded merged 4 commits into
mainfrom
add-gcs-support
Jan 5, 2026
Merged

Add gcs support#5
folded merged 4 commits into
mainfrom
add-gcs-support

Conversation

@folded
Copy link
Copy Markdown
Owner

@folded folded commented Jan 5, 2026

Use fsspec to load data from url-like paths.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @folded, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the gemini_ocr library by enabling it to process documents from remote sources, specifically Google Cloud Storage. By integrating the fsspec library, the system can now interpret URL-like paths, allowing for a more versatile and cloud-friendly approach to document input. This change centralizes input handling and ensures robust functionality across different storage mediums.

Highlights

  • GCS Support: Added support for loading documents directly from Google Cloud Storage (GCS) paths.
  • Dependency Update: Introduced fsspec and gcsfs as new project dependencies to enable flexible file system abstraction.
  • Input Resolution Refactoring: Refactored the input source resolution logic into a new private helper function, _resolve_input, to handle various input types including URL-like paths.
  • Testing: Added new unit tests to specifically verify the handling of GCS paths and ensure backward compatibility for local file paths.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for loading documents from GCS paths by integrating fsspec. The overall approach is sound and the new functionality is covered by tests. However, I've identified a regression where handling of BinaryIO streams has lost the important seek(0) logic, which could lead to errors. I've also suggested a refactoring to improve the maintainability of the new input resolution logic by reducing code duplication. Please see the detailed comments below.

Comment thread src/gemini_ocr/document.py
Comment thread src/gemini_ocr/document.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@folded folded merged commit 899807b into main Jan 5, 2026
2 checks passed
@folded folded deleted the add-gcs-support branch January 5, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant