Repository navigation
UICIRC-1350: Update patron notice template to include Text message format. - #1285
Merged
Merged
Conversation
Jest Unit Test Results 1 files ± 0 192 suites +3 1m 12s ⏱️ +5s Results for commit 85e0d77. ± Comparison against base commit bed0059. This pull request removes 11 and adds 47 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…notice format, add more tests
|
BogdanDenis
approved these changes
Aug 3, 2026
vashjs
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
400+ lines are tests.
Adds a new Text message format alongside the existing Email/Print options for patron notice templates. Key changes:
NOTICE_FORMATSconstant (EMAIL / PRINT / TEXT_MESSAGE) replacing the oldprintOnlyboolean + implicit-email model.SelectforadditionalProperties.noticeFormat, driving whether Subject/Body are enabled, whether the body is plain text, and whether image tokens are offered.parseInitialValues/handleBeforeSaveinPatronNotices.jstranslate between the legacyprintOnlyflag and the new noticeFormat field, and setoutputFormatsaccordingly.KeyValueinstead of "Subject".Related PRs
folio-org/stripes-template-editor#120
folio-org/stripes-core#1752
Issues
https://folio-org.atlassian.net/browse/UICIRC-1350
Screencasts
2026-07-31_14h07_25.mp4
Approach
Refs
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.