refactor: inline classes.trie as Uint8Array & drop base64-js usage at runtime#49
Merged
blikblum merged 1 commit intofoliojs:masterfrom Jun 30, 2025
Merged
Conversation
Member
|
Great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, I wanted to update the
base64-jslibrary to avoid duplication in my project (it's currently fixed here while the rest of the project uses latest version,1.5.1).Then I realized that updating the dependency wasn't a stable solution. Instead, I wanted to move
base64-jsto devDependencies by removing the runtime decoding entirely — since the decoding can be done at the data preparation stage.Finally, I realized there's no need to generate, read, or decode base64 at all. We can directly write the "raw"
Uint8Arrayto a generated file. With this approach,base64-jsbecomes completely unnecessary.