Repository navigation
ci: npm Trusted Publishing으로 전환 (토큰 제거) - #13
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow continues publishing on published GitHub Releases, upgrades Node.js from 20 to 24, and replaces token authentication and explicit provenance flags with npm Trusted Publishing through GitHub OIDC. Changesnpm Trusted Publishing
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubRelease
participant GitHubActions
participant NpmRegistry
GitHubRelease->>GitHubActions: Trigger published release workflow
GitHubActions->>GitHubActions: Issue OIDC identity token
GitHubActions->>NpmRegistry: Run tokenless npm publish
NpmRegistry-->>GitHubActions: Authenticate and generate provenance
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish.yml:
- Line 17: Update the actions/checkout@v4 step in the publish workflow to set
persist-credentials to false, ensuring the checkout does not retain the
GITHUB_TOKEN in local git configuration while leaving the existing workflow
steps unchanged.
- Line 20: Update the Node 24 setup in the publish workflow to ensure npm 11.5.1
or newer is available before the publish step, either by explicitly installing
that npm version or enabling check-latest for Node. Keep the existing npm
publish flow unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7a4742be-76f4-42e1-9434-d1ba4edc45bc
📒 Files selected for processing (1)
.github/workflows/publish.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish.yml:
- Line 26: Update the OIDC publish job’s npm installation step to pin a tested
npm version at or above 11.5.1 instead of using npm@latest, and add
--ignore-scripts to the installation command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8c44df25-d905-4801-ac89-083b0d91e471
📒 Files selected for processing (1)
.github/workflows/publish.yml
npm이 CI/CD용 장기 토큰(2FA bypass) 대신 Trusted Publishing(OIDC) 을 권장하므로 전환한다. Refs #10
변경
NODE_AUTH_TOKEN/NPM_TOKEN제거 — OIDC 단기 토큰으로 인증 (npm CLI가 자동 감지)--provenance플래그 제거 — Trusted Publishing에서는 provenance가 자동 생성됨runs-on: ubuntu-latest유지 (GitHub-hosted 러너만 지원)장점
전제
npm 패키지 설정에 Trusted Publisher 등록 필요 (org
followingseas, repopilot, workflowpublish.yml). 패키지가 존재해야 등록 가능하므로 첫 배포는 로컬에서 1회 수행하고, 이후 릴리스부터 이 워크플로가 담당한다.🤖 Generated with Claude Code
Summary by CodeRabbit