Repository navigation
fix: 업데이트 배너 클릭과 위치 이동 문제 수정 - #61
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough패키지 버전을 Changes업데이트 배너
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is identified in the described changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
빈 화면에 업데이트 배너가 겹칠 때 버튼 입력이 창 드래그로 처리될 여지를 제거하고, 배너가 등장하면서 가로로 튀는 문제를 수정합니다. 창 이동은 상단 바로 제한하고 업데이트 배너의 다운로드·재시작·닫기 버튼에
no-drag를 직접 지정했습니다.배너는 중앙 토스트의
translateX(-50%)애니메이션 대신 투명도만 바꾸는 전용 애니메이션을 사용합니다. 표시 위치와 클릭 영역이 움직이지 않습니다. 이 수정을 배포할 수 있도록package.json과 lockfile 버전을0.11.1로 올렸습니다.검증:
npm run build: 타입 검사와 프로덕션 빌드 통과npm run lint, Prettier,git diff --check통과npm test: 137개 테스트 통과실제 업데이트 파일의 다운로드·설치는 모의 핸들러로 대체했으며, 릴리즈 파일의 빌드·서명·공증은 태그 푸시 후 기존 release 워크플로로 검증합니다.
Summary by CodeRabbit