Conversation
|
Thanks! I'll take a look soon, I'll rebase my related changes on top of this. |
|
This is great, thank you! I'm wondering if it's worth making this change backwards compatible, or should we enforce a hard dependency on LLVM10. It looks like Bionic and newer Ubuntu versions have a proper |
|
I've tested this PR together with #67 and things do work again with stable rust. Keeping backwards compatibility isn't worth it since we operate on LLVM bitcode which isn't stable, so for things to work we must use the same LLVM version used by rustc which at the moment is 10. The only thing that's missing to merge this is changing the CI images to install llvm-10 instead of llvm-9. |
|
Can confirm adding #67 works :)
While you're at it, can you also take a look at other dependencies? I'll follow up in this PR to further cleanup the dependencies list if you let me know the minimum set required. |
|
We have some CI issues at the moment I'll need to take a look at. Thanks both for the contribution, I'll merge #67 along with this. |
(Forgot to mention the reasoning, Rust 1.45 is using LLVM 10 now which is the merge commit from this PR)
The code change should be trivial.
I think we might want to clean up the README a bit, for Ubuntu dependencies:
curlwgetorgnupg2at all?ca-certificates-javaeither?libelfis enough (I just realized I didn't havelibelf-dev- though installing it doesn't solve the load issue I have, and it certainly didn't affectcargo bpf build)zlib1gis needed (forgot about the error message but it's the first error I hit when runningcargo bpf build)linux-headersneed to pick an explicit version, otherwiseapt(apt-gettoo) complainsE: Package 'linux-headers' has no installation candidateIt might also be related to Ubuntu releases, I'm running on 20.04 (Desktop).