fix: cache Secrets in the operator namespace instead of cluster-wide - #2
Merged
Conversation
The credential reconciler watches Secrets, and the manager cached them at cluster scope. Once the Secret grant became a namespaced Role, that informer's list was refused, the shared cache never reported synced, and the manager exited with "failed to wait for ... caches to sync" — a crash loop that took all nine controllers down, not just Credential. Scope the Secret cache to the operator's own namespace so the informer asks only for what the Role grants. The namespace comes from a POD_NAMESPACE downward-API env (added to both the Helm deployment and the kustomize manager manifest), falling back to the ServiceAccount namespace file so an older manifest still scopes correctly. Out-of-cluster runs have neither and keep the unscoped cache, which matches the cluster-admin kubeconfig they use. Verified in the 7-node dev cluster: 0 restarts, all nine controllers start, a Credential CR reconciles its Secret through the scoped cache, and the operator still cannot read Secrets outside its namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M12 left the operator watching Secrets cluster-wide, which put it straight into a crash-loop on a real cluster. Found and fixed against the running dev cluster on 2026-07-23; blocking the 2026.07.0 release because the operator image is built from main.