Move Android bridge to ReactNative repo + New Architecture TurboModules #450
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| is_pr: | ||
| type: boolean | ||
| default: false | ||
|
|
||
| jobs: | ||
| test-android: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| if: ${{ inputs.is_pr }} | ||
| with: | ||
| fetch-depth: 100 | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| - uses: actions/checkout@v4 | ||
| if: ${{ ! inputs.is_pr }} | ||
| with: | ||
| ref: ${{ github.head_ref }} | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| - name: Install Dependencies | ||
| env: | ||
| TEST_CREDENTIALS: ${{ secrets.TEST_CREDENTIALS }} | ||
| run: | | ||
| npm install -g typescript | ||
| cd androidTests | ||
| ./prepareandroid.js | ||
| ./create_test_credentials_from_env.js | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '21' | ||
| - name: Setup Android SDK | ||
| uses: android-actions/setup-android@v3 | ||
| - uses: gradle/actions/setup-gradle@v4 | ||
| with: | ||
| gradle-version: "8.14.3" | ||
| add-job-summary: on-failure | ||
| - name: Build for Testing | ||
| run: | | ||
| cd androidTests/android | ||
| ./gradlew :app:assembleDebug :app:assembleAndroidTest | ||
| - uses: 'google-github-actions/auth@v2' | ||
| if: success() || failure() | ||
| with: | ||
| credentials_json: '${{ secrets.GCLOUD_SERVICE_KEY }}' | ||
| - uses: 'google-github-actions/setup-gcloud@v2' | ||
| if: success() || failure() | ||
| - name: Run Tests on Firebase Test Lab | ||
| if: success() || failure() | ||
| run: | | ||
| APP_APK="androidTests/android/app/build/outputs/apk/debug/app-debug.apk" | ||
| TEST_APK="androidTests/android/app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk" | ||
| gcloud firebase test android run \ | ||
| --type instrumentation \ | ||
| --app "$APP_APK" \ | ||
| --test "$TEST_APK" \ | ||
| --device model=Pixel2,version=33 \ | ||
|
Contributor
There was a problem hiding this comment. Where did this device configuration come from?
Contributor
Author
There was a problem hiding this comment. Saw your comments after merging. |
||
| --timeout 10m \ | ||
| --results-bucket cloud-test-${GITHUB_REPOSITORY_OWNER} \ | ||
| --results-dir "SalesforceReactNative/${GITHUB_RUN_ID}" \ | ||
| --no-record-video | ||
| - name: Copy Test Results | ||
| if: success() || failure() | ||
| run: | | ||
| BUCKET_PATH="gs://cloud-test-${GITHUB_REPOSITORY_OWNER}/SalesforceReactNative/${GITHUB_RUN_ID}" | ||
| mkdir -p firebase_results | ||
| gsutil -m cp -r "${BUCKET_PATH}/*/test_result_*.xml" firebase_results/ 2>/dev/null || true | ||
| - name: Test Report | ||
| uses: mikepenz/action-junit-report@v6 | ||
| if: success() || failure() | ||
| with: | ||
| check_name: Android Test Results | ||
| require_tests: true | ||
| fail_on_failure: true | ||
| report_paths: 'firebase_results/**.xml' | ||
| - name: Archive Test Results | ||
| uses: actions/upload-artifact@v4 | ||
| if: success() || failure() | ||
| with: | ||
| name: test-results-android | ||
| path: 'firebase_results/**.xml' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
|
|
||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:versionCode="94" | ||
| android:versionName="14.0.0.dev"> | ||
|
|
||
| <application> | ||
| <activity android:name=".ui.SalesforceReactActivity" | ||
| android:enableOnBackInvokedCallback="false" /> | ||
| </application> | ||
| </manifest> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| apply plugin: 'com.android.library' | ||
| apply plugin: 'org.jetbrains.kotlin.android' | ||
|
|
||
|
|
||
| android { | ||
| namespace "com.salesforce.androidsdk.reactnative" | ||
| compileSdk 36 | ||
|
|
||
| defaultConfig { | ||
| minSdk 28 | ||
| } | ||
|
|
||
| sourceSets { | ||
| main { | ||
| manifest.srcFile "AndroidManifest.xml" | ||
| java.srcDirs = ["src/main/java"] | ||
| res.srcDirs = ["res"] | ||
| assets.srcDirs = ["assets"] | ||
| } | ||
| } | ||
|
|
||
| buildFeatures { | ||
| buildConfig true | ||
| aidl true | ||
| } | ||
|
|
||
| packaging { | ||
| resources { | ||
| excludes += ['META-INF/LICENSE', 'META-INF/LICENSE.txt', 'META-INF/DEPENDENCIES', 'META-INF/NOTICE'] | ||
| } | ||
| } | ||
|
|
||
| lint { | ||
| abortOnError false | ||
| } | ||
| } | ||
|
|
||
| kotlin { | ||
| jvmToolchain(17) | ||
| } | ||
|
|
||
| dependencies { | ||
| api 'com.salesforce.mobilesdk:MobileSync:14.0.0' | ||
| api 'com.facebook.react:react-android:0.81.5' | ||
| implementation 'androidx.core:core-ktx:1.18.0' | ||
| } | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very NIT: This is probably out of date. This won't cause the build to fail or anything, it will just take more time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw your comments after merging.
Will revisit in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here: c9941ba