Skip to content

[auto-generated] Fix CI: Use generic simulator destination in test_template.sh#526

Merged
brandonpage merged 1 commit into
forcedotcom:devfrom
brandonpage:fix/ci-20260601-generic-simulator-dest
Jun 1, 2026
Merged

[auto-generated] Fix CI: Use generic simulator destination in test_template.sh#526
brandonpage merged 1 commit into
forcedotcom:devfrom
brandonpage:fix/ci-20260601-generic-simulator-dest

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

Summary

  • Replace hardcoded name=iPhone 17 simulator destination with portable generic/platform=iOS Simulator
  • This makes the build step work across all Xcode versions without requiring specific device names

Root Cause

test_template.sh line 139 hardcoded platform=iOS Simulator,name=iPhone 17 but CI runners (macos-15) use Xcode 16.4 which only ships iPhone 16 simulators. "iPhone 17" requires Xcode 17+.

Test plan

  • Verify iOSNativeSwiftTemplate builds successfully in CI
  • Verify other iOS templates also build (if they use the same function)
  • Confirm no regression on template generation

Root cause: test_template.sh hardcodes 'name=iPhone 17' which requires Xcode 17+
Failing test(s): iOSNativeSwiftTemplate build on macos-15 with Xcode 16.4
Fix: Replace device-specific destination with 'generic/platform=iOS Simulator'
which works across all Xcode versions without requiring a specific simulator
Copy link
Copy Markdown
Contributor Author

@brandonpage brandonpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonpage brandonpage merged commit 868eb40 into forcedotcom:dev Jun 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants