Repository navigation
Open
Labels
out-of-sowNot an Instawards deliverableNot an Instawards deliverableready-to-devUnblocked: development can start on the issue's branchUnblocked: development can start on the issue's branch
Description
Owner: @Lin1er · Branch: feat/admob-relay · Parent: #90 · Was blocked by: #93, done 2026-10-26 (both parts) · Start: now on the branch, pending @Lexirieru's go on #90 for merging before 2026-10-30 (otherwise after 2026-11-08) · Label: out-of-sow
An AdMob provider on the relay, beside AdSense, selected by source on POST /proofs.
What
be/src/admob/, the same shape asbe/src/adsense/:request.ts:POST https://admob.googleapis.com/v1/accounts/pub-…/networkReport:generate;- a fixed
reportSpec:dateRangefrom the same trailing three complete months,metrics: ["ESTIMATED_EARNINGS"], no dimensions,localizationSettings.currencyCode: "USD"; - the token in
secretOptions.headersonly.
- RE2
responseMatchesfor the currency and themicrosValuetotal, written against the real responses from Spike (#90): zkFetch POST body signing, and AdMob's response at zero and above #93 part 2. audit.ts: the same checks as for AdSense, with the host pinned toadmob.googleapis.com.account.ts:accounts.listto find exactly one AdMob account, with the sameaccounterrors.
POST /proofstakessource: "adsense" | "admob", defaulting toadsense, so today's clients keep working.- A token whose granted scopes do not include the source's scope is refused with
token.
- A token whose granted scopes do not include the source's scope is refused with
- The zero case.
- If Spike (#90): zkFetch POST body signing, and AdMob's response at zero and above #93 shows AdMob omits the row at $0 (as AdSense omits
totals), the relay stops before the attestor withprovider, as it does for AdSense.
- If Spike (#90): zkFetch POST body signing, and AdMob's response at zero and above #93 shows AdMob omits the row at $0 (as AdSense omits
- Docs.
docs/api.mdgetssourceand the new errors.docs/adsense-provider.mdgets a siblingdocs/admob-provider.md.
Done when
- Unit tests cover the request, regex, audit and account paths.
- One real AdMob proof comes out of
POST /proofs. That is the input to the template issue. - The relay is redeployed, with the change recorded in
docs/deployments.md.
Working agreement
- One issue, one owner. 2. Branch per issue, named above, not the GitHub-suggested one. 3. MCP Stellar Raven for any Stellar/Soroban fact that gets written down. 4. Merge through PR review by Axel (PM); no self-merge. If an ACC has not arrived within two days on something already verified, merge and say so in the PR. 5. Deploys need evidence: contract address or tx hash on stellar.expert, recorded in
docs/deployments.md. 6. Secrets live in.env, gitignored,chmod 600: never printed, never committed, never pasted into an issue or PR. Only publicG…andC…addresses appear anywhere. 7. Issues, commits and PRs in English.
Metadata
Metadata
Assignees
Labels
out-of-sowNot an Instawards deliverableNot an Instawards deliverableready-to-devUnblocked: development can start on the issue's branchUnblocked: development can start on the issue's branch
Activity
Lin1er commentedon Oct 26, 2026
Code in draft as #100: the provider,
sourceonPOST /proofs,prove:admob, and the docs. 117 BE tests pass. It stays in draft until @Lexirieru's go on #90.Still open here: one real proof through
prove:admob(the input to #96), which needs the account owner's token and their agreement; and the redeploy once #100 merges.fix(#95): AdMob at zero fails with its own code, empty, not provider
fix(#95): AdSense at zero fails as empty too
feat(#95): an AdMob provider beside AdSense, selected by source on PO…
fix(#95): AdMob at zero fails with its own code, empty, not provider
fix(#95): AdSense at zero fails as empty too
test(#95): an AdMob proof is held to the relay's own claim owner too (#…
feat(#95): an AdMob provider beside AdSense, selected by source on PO…
fix(#95): AdMob at zero fails with its own code, empty, not provider
fix(#95): AdSense at zero fails as empty too
test(#95): an AdMob proof is held to the relay's own claim owner too (#…
feat(#95): an AdMob provider beside AdSense, selected by source on PO…
Lin1er commentedon Nov 1, 2026
Status: both items left open here are done.
prove:admob: done on 2026-10-26. It was signed by the production attestor and passed the relay audit. AdMob (#90): pin the AdMob claim template from a real proof #96's template was derived from it, and that template is now pinned on both contracts (The contract rebuilds the attestor's owner as the borrower, so no real proof can verify #102).main, which includes it, and is recorded on docs(#17): the relay host runs main, at 2ea1e15 #99.@Lexirieru: I think this can close once the first live AdMob advance lands on #102. The same goes for #93: the spike answered both questions, and #95/#96 shipped on its findings.