Skip to content

AdMob (#90): relay, the AdMob provider and source on POST /proofs #95

Open

Description

@Lin1er

Owner: @Lin1er · Branch: feat/admob-relay · Parent: #90 · Was blocked by: #93, done 2026-10-26 (both parts) · Start: now on the branch, pending @Lexirieru's go on #90 for merging before 2026-10-30 (otherwise after 2026-11-08) · Label: out-of-sow

An AdMob provider on the relay, beside AdSense, selected by source on POST /proofs.

What

  1. be/src/admob/, the same shape as be/src/adsense/:
    • request.ts:
      • POST https://admob.googleapis.com/v1/accounts/pub-…/networkReport:generate;
      • a fixed reportSpec: dateRange from the same trailing three complete months, metrics: ["ESTIMATED_EARNINGS"], no dimensions, localizationSettings.currencyCode: "USD";
      • the token in secretOptions.headers only.
    • RE2 responseMatches for the currency and the microsValue total, written against the real responses from Spike (#90): zkFetch POST body signing, and AdMob's response at zero and above #93 part 2.
    • audit.ts: the same checks as for AdSense, with the host pinned to admob.googleapis.com.
    • account.ts: accounts.list to find exactly one AdMob account, with the same account errors.
  2. POST /proofs takes source: "adsense" | "admob", defaulting to adsense, so today's clients keep working.
    • A token whose granted scopes do not include the source's scope is refused with token.
  3. The zero case.
  4. Docs. docs/api.md gets source and the new errors. docs/adsense-provider.md gets a sibling docs/admob-provider.md.

Done when

  • Unit tests cover the request, regex, audit and account paths.
  • One real AdMob proof comes out of POST /proofs. That is the input to the template issue.
  • The relay is redeployed, with the change recorded in docs/deployments.md.

Working agreement

  1. One issue, one owner. 2. Branch per issue, named above, not the GitHub-suggested one. 3. MCP Stellar Raven for any Stellar/Soroban fact that gets written down. 4. Merge through PR review by Axel (PM); no self-merge. If an ACC has not arrived within two days on something already verified, merge and say so in the PR. 5. Deploys need evidence: contract address or tx hash on stellar.expert, recorded in docs/deployments.md. 6. Secrets live in .env, gitignored, chmod 600: never printed, never committed, never pasted into an issue or PR. Only public G… and C… addresses appear anywhere. 7. Issues, commits and PRs in English.

Activity

  1. self-assigned this
    on Oct 25, 2026
  2. added
    ready-to-devUnblocked: development can start on the issue's branch
    on Oct 26, 2026
  3. Lin1er commented on Oct 26, 2026

    @Lin1er
    CollaboratorAuthor

    Code in draft as #100: the provider, source on POST /proofs, prove:admob, and the docs. 117 BE tests pass. It stays in draft until @Lexirieru's go on #90.

    Still open here: one real proof through prove:admob (the input to #96), which needs the account owner's token and their agreement; and the redeploy once #100 merges.

  4. added 10 commits that reference this issue on Oct 27, 2026
  5. added a commit that references this issue on Oct 30, 2026
  6. Lin1er commented on Nov 1, 2026

    @Lin1er
    CollaboratorAuthor

    Status: both items left open here are done.

    @Lexirieru: I think this can close once the first live AdMob advance lands on #102. The same goes for #93: the spike answered both questions, and #95/#96 shipped on its findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

out-of-sowNot an Instawards deliverableready-to-devUnblocked: development can start on the issue's branch

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions